Skip to content

Combine Yamaha SY77 and TG77 voice adaptations - #598

Draft
christofmuc wants to merge 3 commits into
masterfrom
codex/yamaha-77-integration
Draft

christofmuc wants to merge 3 commits into
masterfrom
codex/yamaha-77-integration

Conversation

@christofmuc

Copy link
Copy Markdown
Owner

Combined voice support

This draft combines the SY77 and TG77 work from #551 and #597. It preserves the original contribution commits and all four SysEx fixture files (204 messages). There are separate Yamaha SY77 and Yamaha TG77 entries with one shared voice implementation.

  • Internal voices and both preset banks can be read. The two preset banks are read-only.
  • The first factory preset identifies the model. A separate System dump supplies the Voice Receive Channel. Detection leaves Bulk Protect as set on the instrument.
  • SY77 keeps its direct edit-buffer request and Direct-mode Program Change. Preset 1 uses voice-bank selector 124. TG77 keeps Giovanni's timed Edit → Dump → Voice sequence and Normal-mode Program Change for the selected Internal bank.
  • Writes are checked against the requested slot, including the Bank D-only voice modes. A dedicated bank-dump writer is deferred. The app's existing per-slot bank send can stop partway through, so back up internal memory and test scratch slots first.

Contributions and hardware baseline

  • @hmmbug contributed the original SY77 and TG77 adaptations, the bank mapping and three fixtures. The SY77 adaptation was reported stable after several weeks on SY77 ROM 1.5. Original SY77 hardware report
  • Giovanni Candiago contributed the TG77-tested implementation and the fixture with 64 internal voices and all 11 voice modes. He verified detection with his original System-dump probe, edit-buffer read and send, reads of all 64 internal voices, front-panel dumps, and Normal-mode Program Change with separate SysEx and voice channels. Original TG77 contribution

Validation and retest

  • Full Python 3.12 adaptation suite: 1,435 passed, 2,348 skipped.
  • The generated support matrix is current. Both adaptations imported from a staged packaging layout. All four fixtures matched their original Git blobs.
  • SY77 retest on the combined draft, including detection, both preset banks, large edit-buffer transfer, and Preset 1 selection from Multi mode.
  • TG77 retest on the combined draft, including detection with different SysEx and voice channels, the large edit-buffer transfer, front-panel dumps, and Normal-mode Program Change.
  • Verify internal write behavior using backed-up scratch slots on both models.

See the setup notes and hardware checklist for the full steps. The other Yamaha models in #551 can continue through their own review.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants